Only include dependencies from the csproj in the project_path to review #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason we are still downloading dependencies from lockfiles outside the project path altogether? Is it necessary for the build? At the very least, I think we should not download things we aren't also tracking, since that defeats the purpose of it a little bit IMO. Code looks good otherwise! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adjusts the way that Plogon collects the nuget packages that are listed to review. It does this by restoring all the packages but only adding the ones that are collected from the csproj within the project_path provided by the plugin. If no project_path is provided in the plugin's manifest, it'll include every package as it was doing before.
The primary use case for this is when you have a structure like this
PrimaryPlugin/PrimaryPlugin.csproj - Only includes TertiaryLibrary.csproj
TertiaryLibrary/TertiaryLibrary.csproj
NotIncluded/NotIncluded.csproj
Before the changes it'd pick up the nuget packages on all 3 csproj files, but after it only picks up the nuget packages on PrimaryPlugin and TertiaryLibrary.